Login

russian armor

Livestreams cannot open in new tab

7 Jan 2013, 14:50 PM
#1
avatar of Qvazar

Posts: 881

Since an update not long ago, livestreams cannot be opened in a new tab by ctrl+click or middle-click.
Right-click->"Open in new tab" works fine.

I see this is because of the trackStream function calling e.preventDefault() and "manually" changing window.location to the stream url.

A solution could be to remove the e.preventDefault() call, but I see why it's there.. maybe somehow detect if a new tab should be opened and calling window.open(url, "_blank") instead?

A more elegant solution would be to change the actual link to the
Code
'/livestream/performView/chan_id/'+parseInt($(this).data('id'))
-value and having that page respond with a redirect to the actual stream url.
7 Jan 2013, 14:51 PM
#2
avatar of Qvazar

Posts: 881

As it is now, the /livestream/performView/chan_id/ url never gets called if I open in a new tab by right-clicking :)
7 Jan 2013, 14:52 PM
#3
avatar of hicksi
Admin Black Badge

Posts: 983 | Subs: 3

We don't want to work with user redirect, its a bad behavior imho.

I'm not sure what/who broke that, but thanks I will look into it :)

What browser do you use? On Firefox it seems all fine.
7 Jan 2013, 15:07 PM
#4
avatar of hicksi
Admin Black Badge

Posts: 983 | Subs: 3

I can't reproduce the error. Check if its fixed now please.
7 Jan 2013, 15:22 PM
#5
avatar of Qvazar

Posts: 881

Ah, it works fine in list view, but mixed and grid view ignores ctrl- and middle-click for new tab.
I'm using Chrome btw.
Seb
7 Jan 2013, 23:21 PM
#6
avatar of Seb
Admin Black Badge

Posts: 3709 | Subs: 2

It works fine on firefox but confirmed not working on chrome. :o
7 Jan 2013, 23:31 PM
#7
avatar of AmiPolizeiFunk
Admin Black Badge
Patrion 15

Posts: 16697 | Subs: 12

I have "Yes" selected under board options for opening links in new tabs. When I click on a livestream, it does not open in a new tab. Should it? I would like it if it did.
8 Jan 2013, 00:38 AM
#8
avatar of Qvazar

Posts: 881

The livestream list on the right side has the same problem :(
Seb
8 Jan 2013, 12:47 PM
#9
avatar of Seb
Admin Black Badge

Posts: 3709 | Subs: 2

The option in board is not supposed to open them in new tab, it only applies to links coming from text area/bbcode. Doing same for stream would be a good addition though.
27 Jan 2013, 12:08 PM
#10
avatar of Turtlelord

Posts: 15

I confirm the same for Chrome, FF 17 and 18, Opera and IE9.
About to test for IE10 and will update.
It would indeed be neat to open streams in new windows but hey, how hard is a middle click?

27 Jan 2013, 12:29 PM
#11
avatar of Qvazar

Posts: 881

A middle click isn't hard, but middle/ctrl-click doesn't work in the sidebar stream list or in mixed view. :(
27 Jan 2013, 17:55 PM
#12
avatar of hicksi
Admin Black Badge

Posts: 983 | Subs: 3

should be fixed now. can you confirm?
Seb
27 Jan 2013, 18:47 PM
#13
avatar of Seb
Admin Black Badge

Posts: 3709 | Subs: 2

It opens both in current and new tab now. :s
27 Jan 2013, 18:58 PM
#14
avatar of Qvazar

Posts: 881

jump backJump back to quoted post27 Jan 2013, 18:47 PMSeb
It opens both in current and new tab now. :s

Haha, yes it does! It's a step in the right direction! ;)
27 Jan 2013, 19:10 PM
#15
avatar of hicksi
Admin Black Badge

Posts: 983 | Subs: 3

oh okay lol fuck, i swear it didn't behave like that when i tested or it was just pretty slow

-edit-

found error, will push to live later
27 Jan 2013, 20:34 PM
#16
avatar of hicksi
Admin Black Badge

Posts: 983 | Subs: 3

okay we fixed the error. please confirm. futhermore we changed the default open behavior of all livestream links to "not in a new tab" - to follow our "open new link" - philosophy of this site.
Seb
27 Jan 2013, 20:52 PM
#17
avatar of Seb
Admin Black Badge

Posts: 3709 | Subs: 2

ctrl-click still not working. middle mouse seems ok. Why even change default browser behaviour in the first place?
27 Jan 2013, 21:07 PM
#18
avatar of hicksi
Admin Black Badge

Posts: 983 | Subs: 3

just adapted the behavior from the old fulltimegeek page, before we made the decision that open a link in a new tab or not is a user choice.

but thats not the point why it worked before and not "anymore". we simply rewrote the js function a few weeks ago :)

ctrl+click imho not so important (gamers use this site and i assume they have a wheelmouse :p), but we will add that too.
27 Jan 2013, 23:38 PM
#19
avatar of Turtlelord

Posts: 15

Yep, middle-click works on main list and side list.
I would still like ot know the rationale behind having stream open in the main COH2 window instead of somewhere separately. OFC, it's none of my business, just wanted to know.
27 Jan 2013, 23:44 PM
#20
avatar of Qvazar

Posts: 881

I've lost count of the many times I've closed a tab because I was done with it, only to realize I'd just closed my coh2.org tab :(
I'm used to external links opening in new tabs on all other sites. :|
1 user is browsing this thread: 1 guest

Ladders Top 10

  • #
    Steam Alias
    W
    L
    %
    Streak
Data provided by Relic Relic Entertainment

Replay highlight

VS
  • U.S. Forces flag cblanco ★
  • The British Forces flag 보드카 중대
  • Oberkommando West flag VonManteuffel
  • Ostheer flag Heartless Jäger
uploaded by XXxxHeartlessxxXX

Board Info

948 users are online: 948 guests
0 post in the last 24h
0 post in the last week
28 posts in the last month
Registered members: 49427
Welcome our newest member, Baqis73421
Most online: 2043 users on 29 Oct 2023, 01:04 AM